Remove ORC from Iceberg module - #36100
Conversation
|
R: @kennknowles |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ahmedabu98, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request streamlines the Apache Iceberg module by completely removing support for the ORC file format. This change is driven by the format's low adoption within the module and the presence of security vulnerabilities (CVEs) in its associated dependencies. By eliminating ORC, the project reduces its attack surface, simplifies dependency management, and maintains a more focused and secure codebase.
Highlights
- Deprecation of ORC Format Support: The ORC (Optimized Row Columnar) file format support has been completely removed from the Iceberg module.
- Security and Maintenance Improvement: This removal addresses security vulnerabilities (CVEs) associated with ORC dependencies and streamlines the codebase by eliminating support for a rarely used format.
- Build and Codebase Simplification: ORC-related dependencies, imports, and code paths have been entirely removed from the Iceberg module's build configuration and source files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
|
If it turns out someone wants it, we can switch to a serviceloader architecture or something like that so it can be a separate dependency. |
2 participants
It's not a widely used format, and it's pulling in CVEs that require an ORC version beyond what Iceberg's latest version uses.